Major refactor to allow lazy sync iterators. #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes DelfinaCare#6. Because the code was getting too unweildy and hard to follow, I refactored the iterator proxies to their own classes in a separate file.
We yield only outside the lock to avoid potential deadlocks.
mattalbr
requested changes
Oct 10, 2023
Response to comment from DelfinaCare#10
We use an enum to thoroughly document the possible states the yielding function can be in, making the code a lot more readable IMHO!
aebrahim
force-pushed
the
sync_iterators_lazy
branch
from
ba26773
to
cf63c61
Compare
mattalbr
requested changes
Oct 11, 2023
once/_iterator_wrappers.py
Outdated
| self.finished = True | ||
| self.generator = None # Allow this to be GCed. | ||
| self.generating = False | ||
| else: |
There was a problem hiding this comment.
nit: It's hard to tell if this else is on the if or the try. I think you could just in-line the else below result = self.generator.send(next_send), like:
try:
result = self.generator.send(next_send)
with self.lock:
self.results.append(result)
self.generating = False
except StopIteration:
...It is no longer set on the object, per discussion.
mattalbr
requested changes
Oct 11, 2023
mattalbr
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6.
Because the code was getting too unweildy and hard to follow, I refactored the iterator proxies to their own classes in a separate file.